NatLabRockies / NatLabRockies/OpenStudio

Chiller EIR default rated condition and curves don't match

Open
#2,093 11 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

component - HVAC severity - Normal Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

The Default Chiller:ElectricEIR creates has a problem... At the rated conditions, the CAPFT and EIRFT will return a value different than 1.

model = OpenStudio::Model::Model.new
chiller = OpenStudio::Model::ChillerElectricEIR.new(model)
ref_lchwt = chiller.referenceLeavingChilledWaterTemperature
ref_ecnwt = chiller.referenceEnteringCondenserFluidTemperature
eirft = chiller.electricInputToCoolingOutputRatioFunctionOfTemperature

# EIRFT is wrong
eirft.evaluate(ref_lchwt, ref_ecnwt)
# => 0.8614399290202399

# CAPFT is wrong
capft = chiller.coolingCapacityFunctionOfTemperature
capft.evaluate(ref_lchwt, ref_ecnwt)
# => 1.0554712015060401

# EIRFPLR is ok
eirfplr = chiller.electricInputToCoolingOutputRatioFunctionOfPLR
eirfplr.evaluate(1)
# => 1.00138225

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.