NatLabRockies / NatLabRockies/OpenStudio
OptionalSpace or Space.fromFloorPrint generate surfaces of arbitrary ordering
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
When an optionalspace is generated using the Space.fromFloorPrint method, and following a space is generated from the optionalspace, the surfaces of this space are in arbitrary ordering. wouldn't it make more sense if the six surfaces that bound that space are ordered by floor + 4 walls in the order that the points are read into the Point3dVector + the ceiling?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Space.fromFloorPrint and the generation of a following space from an OptionalSpace, then inspect how the resulting surfaces are ordered relative to the Point3dVector input. Done means the six bounding surfaces have deterministic floor, wall, and ceiling ordering matching the requested convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100