NatLabRockies / NatLabRockies/OpenStudio
YearDescription assumes simulation starts on Jan 1
Open
Nobody has claimed this yet.
component - TimeDate
severity - Normal Bug
- Dominant language
- C++
- Stars
- 646
- Forks
- 237
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 10
Description
https://github.com/NREL/OpenStudio/blob/develop/openstudiocore/src/utilities/time/Date.cpp#L137
YearDescription should have an optional month and day field that can be matched with the run period object in the model
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Date.cpp at line 137 and trace how YearDescription represents the simulation start and how it relates to the run period object in the model. Done means YearDescription can optionally carry a month and day that match the model's run period; the issue does not mention a test file, so identify the relevant existing time or model tests while tracing the code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100