NatLabRockies / NatLabRockies/OpenStudio

Grotesque assumptions are being made about start times of interval schedules

Open
#1,838 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component - TimeDate severity - Normal Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Interval schedules aren't doing enough checking of input time series. In certain situations, that means that calling the timeSeries() method won't return the same time series that was used to construct the schedule and bad stuff happens at forward translation time. I believe this applies to both fixed and variable interval schedules.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the timeSeries() method for fixed and variable interval schedules and the forward-translation path it feeds. Compare the constructed input series with the returned series, then determine and test the required input-time checks so both schedule variants preserve the expected series before translation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.