NatLabRockies / NatLabRockies/OpenStudio

Improve performance of ScheduleRuleset translation

Open
#1,451 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component - TimeDate Performance severity - Normal Bug
Dominant language
C++
Stars
646
Forks
237
Avg merge
3d 11h
Merged PRs (30d)
10

Description

Forward translating the example model still spends a good chunk of time in schedule translation, specifically ScheduleRuleset_Impl::getDaySchedules and ScheduleRuleset_Impl::getActiveRuleIndices.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the forward-translated example model as the reproduction case. Profile ScheduleRuleset_Impl::getDaySchedules and ScheduleRuleset_Impl::getActiveRuleIndices to understand their contribution to schedule translation, then verify that the translation remains correct while taking less time.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.