NatLabRockies / NatLabRockies/MoorPy
getLineProps arguments check
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 53
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Description
Description
On dev branch, in getLineProps function of helpers.py lines 622-665, there is a check for having both the source and lineProps arguments not None, but it is only done after assigning the inputs from the yaml file to the lineProps variable, so the if not lineProps==None statement can never be False.
Current behavior
Warning: both lineProps and source arguments were passed to getLineProps. lineProps will be ignored is always printed out if source is not None, regardless of the lineProps argument.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in helpers.py, at getLineProps around lines 622-665, and trace how YAML inputs are assigned before the warning check. Reproduce calls with source alone and with both source and lineProps, then inspect the existing tests or add focused coverage. Done means the warning appears only when both arguments are actually provided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 74/100