NatLabRockies / NatLabRockies/H2Integrate

SLC: Technology to SLC connections

Open
#863 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

SLC: Technology to SLC connections

I thought I had this in part of another issue but I can't find it. Some future system-level controller may require additional information about a technology that is not by default connected in the H2I framework. For inputs to the SLC models, both the SLC and H2I need to know what this input is (so the SLC can make it an input and H2I can connect it). Since some on-going work in SLC methods leverages the technology_interconnections so heavily - I think that the control-specific or user-input connections from technologies to SLC models should be in a separate connections list that is not technology_interconnections. I propose that, for example, it'd look like this:

system_level_control:
   control_connections:
     - [battery, system_level_controller, [SOC, battery_electricity_SOC]]

I'd imagine that most connections would be length 3 connections like above. H2I could easily handle these connections in add_system_level_controller() and the SLC baseclass could easily handle this in its setup() method, by looking at these specific connections provided in the slc_topology and looking at the destination name. I suppose one tricky part is handling the units - but perhaps existing logic in the SLC baseclass can support that or that information can be provided elsewhere in the SLC topology. This would be most relevant for system level controllers that are probably more architecture-specific and more advanced in their logic. This would likely be a follow-up to resolving Issue #748

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing H2I's add_system_level_controller(), the SLC base class setup() method, and the existing technology_interconnections handling. Compare the proposed control_connections structure with the slc_topology and Issue #748, including how destination names and units should be represented. Done means agreeing on the connection model and implementing consistent handling in both H2I and SLC.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.