NatLabRockies / NatLabRockies/H2Integrate
Rename `discount_rate` to `real_discount_rate` where appropriate
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Rename discount_rate to real_discount_rate where appropriate
To reduce potential confusion with the discount rate definition and how inflation rate is included or not, we could rename throughout the codebase.
This is mostly relevant for ProFAST and Numpy NPV calcs, but would impact all of the examples and tests, so I'd want to make it in one quick big PR.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for discount_rate, focusing first on the ProFAST and NumPy NPV calculations mentioned in the issue. Review all affected examples and tests, then confirm that the rename is applied consistently and that the full relevant test suite still passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100