NatLabRockies / NatLabRockies/H2Integrate

Are multiple feedstocks handled correctly in SLC?

Open
#789 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

Are multiple feedstocks handled correctly in SLC?

@genevievestarke is working on a fuel cell related system level control problem.
The fuel cell has both oxygen and hydrogen as input feedstocks.
When you set the price in your plant_config's SLC setup as feedstock, does this correctly account for multiple feedstocks?

Proposed solution

Create tests for handling multiple feedstocks.
If it already works, this issue is resolved by adding those tests.
If it doesn't, we'll need to sum up the costs of the feedstocks in an intelligent and generalizable way.

Alternatives considered

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SLC setup handling for feedstock prices in plant_config and any existing tests for fuel-cell or feedstock costs. Add coverage for oxygen and hydrogen together; done means the tests confirm correct multi-feedstock accounting, or expose a generalizable summed-cost behavior that is then covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.