NatLabRockies / NatLabRockies/H2Integrate
Variable dt: Rate and amount units for storage models
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
This issue is to discuss how to make the storage and dispatch models in H2I compatible with variable dt time steps.
Some things that came up on a first pass of this are
- The rate and amount units in H2I are specified as openmdao units. Would it make sense to be able to define rates in units of
amount/dtinstead of an existing unit. An example of this is should batteries be defined in units of kW/hr for charge/discharge rate, and then converted to kW/dt? Would the electricity time amount be kWh, or kW*dt? - Similarly, if you are storing/dispatching hydrogen, the charge/discharge rate is in kg/hr. Should this be in kg/dt instead (i.e. kg/half hour for a 30 minute time step)?
- What does the
dt_hrvariable do, and should this be changed or should the input units be changed?
During initial discussions with/ @elenya-grant, it seems like there might be a benefit to handling mass-based commodities (h2) differently than electricity-based commodities based on the intuitiveness of the units definitions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the storage and dispatch models and trace how the dt_hr variable is currently used. Compare the proposed rate and amount unit conventions for electricity and hydrogen, then define the agreed behavior and document the resulting compatibility requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100