NatLabRockies / NatLabRockies/H2Integrate
Add a check to H2IntegrateModel to check simulation length
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Add a check to H2IntegrateModel to check simulation length
Just like we have #635 for timestep duration, we should create a check on supported models for simulation length.
Proposed solution
It's probably easier to do a similar solution for both issues.
See the discussion on #635 for more context.
Alternatives considered
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #635 and locating H2IntegrateModel, then trace how the timestep-duration check is implemented. Apply the corresponding approach to simulation length for supported models; done means the model rejects unsupported simulation lengths and the relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100