NatLabRockies / NatLabRockies/H2Integrate

Generalize multivariable commodity combiner

Open
#627 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

This combiner seems like it could be generalized to other multi-variable commodity streams (even though we don't have others at the moment). Would it be possible to general this to any multi variable commodity streams or nah?

If so - I think we should remove the default value for stream_type.

Originally posted by @elenya-grant in https://github.com/NatLabRockies/H2Integrate/pull/480#discussion_r2989113850

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file, test, or entry point; start by locating the multivariable commodity combiner and inspect how stream_type is handled. Determine whether it can support arbitrary multivariable commodity streams, then verify that the default stream_type is removed if generalization is viable.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.