NatLabRockies / NatLabRockies/H2Integrate

Refactor/Fix/Update `tech_to_dispatch_connections`

Open
#620 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

From PR #615 by @kbrunik

I understand that this isn't the point of this PR but it illuminated to me that we have some weird logic in the plant_config. I vote that we potentially make an issue about it.
I think it's ambiguous that it says "tech_to_dispatch_connections" but excludes the open-loop controllers. I vote either we update this name to be more clear that this isn't used for open loop dispatch or we add all dispatch to the "tech_to_dispatch_connections". We also need to spell this out in documentation. It's currently not included.

Originally posted by @kbrunik in https://github.com/NatLabRockies/H2Integrate/pull/615#discussion_r2976853100

I also think that this is partially related to the differences between the Heuristic Pyomo controller and the Optimized Pyomo controller.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the plant_config logic and comparing the Heuristic Pyomo and Optimized Pyomo controllers, especially how open-loop dispatch is handled. Resolve whether tech_to_dispatch_connections should be renamed or expanded to include all dispatch, then document the chosen behavior and its distinction from the controllers.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, documentation
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.