NatLabRockies / NatLabRockies/H2Integrate
Generalize efficiency setting for storage models
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Generalize efficiency setting for storage models
We currently allow either roundtrip_efficiency or charge_efficiency and discharge_efficiency parameters as inputs to the pyomo storage controller. We should generalize this to allow for the definition of all possible two-out-of-three combinations.
Additionally, we should only allow 2 out of 3 to be defined to prevent the efficiency from being over-constrained.
Proposed solution
Alternatives considered
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Pyomo storage controller and the existing roundtrip_efficiency, charge_efficiency, and discharge_efficiency parameters. Trace how these inputs are validated and used, then support every valid two-of-three combination while rejecting definitions that over-constrain efficiency; done means the accepted and rejected combinations behave consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100