NatLabRockies / NatLabRockies/H2Integrate
Open loop storage controller outputs zero valued set point when charging battery with zero valued demand
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Open loop storage controller outputs zero valued set point when charging battery with zero valued demand
This happens because commodity_out was renamed to commodity_set_point without adjusting the logic, which means the set point actually represents the total commodity out of the system, including inflow commodity and storage.
How to reproduce
Set demand to zero with positive inflow and uncharged battery
Relevant output
{commodity}_set_point
System Information
Relevant library versions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the open loop storage controller case with zero demand, positive inflow, and an uncharged battery, then trace how commodity_set_point is produced after the commodity_out rename. Confirm the corrected output against the intended set-point semantics and add or update coverage for this scenario if the relevant test location is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100