NatLabRockies / NatLabRockies/H2Integrate

Tests that are needed, should be moved, or should be reformatted

Open
#481 2 comments 0 reactions 2 assignees View on GitHub

@elenya-grant is already working on this.

Since Feb 3, 2026.

Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

While I was working on Pr #463 I found a good handful of tests that are missing, formatted to use unittest rather than pytest or are integration tests that should be relocated out of a tech-specific folder.

Models that need more thorough unit tests

There are no unit tests for the below models, only tests that may exist (from PR #463) are just ensuring that the outputs are populated, not checking specific values or logic (do outputs change as expected if inputs change)

  • methanol models (smr and co2h)
  • pem electrolyzer tests for the performance model decoupled from the cost model (h2integrate/converters/hydrogen/pem_electrolyzer.py)
  • simple steel performance model h2integrate/converters/steel/steel.py
  • hydro power h2integrate/converters/water_power/hydro_plant_run_of_river.py

Tests that are integration tests and should be moved

  • h2integrate/converters/ammonia/test/test_ammonia_synloop_model.py::test_size_mode_outputs
  • h2integrate/converters/hydrogen/test/test_size_modes.py::test_resize_by_max_feedstock
  • h2integrate/converters/hydrogen/test/test_size_modes.py::test_resize_by_max_commodity

Tests that should be reformatted to use pytest

  • h2integrate/converters/co2/marine/test/test_doc.py
  • h2integrate/converters/grid/test/test_grid.py
  • h2integrate/converters/co2/marine/test/test_oae.py
  • h2integrate/finances/test/test_finances.py
  • h2integrate/core/test/test_utilities.py
  • h2integrate/core/test/test_feedstocks.py

Examples that are untested

  • examples/23_solar_wind_ng_demand/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.