Charge and discharge efficiencies set in dispatch are not passed on to battery performance model

Charge and discharge efficiencies set in dispatch are not passed on to battery performance model

You can set charge_efficiency and discharge_efficiency as inputs to the battery for dispatch, but these are not passed on the the pysam battery performance model. They are implemented if you are using the open loop control scheme and the generic storage model, but not if you are using the pyomo dispatch with the pysam battery as the performance model. This means that the charge and discharge efficiencies are taken into account in the pyomo dispatch, but then are not reflected by the battery performance.

How to reproduce

This can be seen if the charge_efficiency and discharge_efficiency parameters are changed in the dispatch input.

Fix Suggestion

Adding a generic storage performance (or battery performance) model that can be parameterized may be useful here. It could also serve as a generic LDES model.

Start by tracing the dispatch inputs for charge_efficiency and discharge_efficiency through the Pyomo dispatch path into the PySAM battery performance model. Compare this with the open-loop control and generic storage behavior described in the issue. Done means both efficiencies set in dispatch are reflected by the battery performance model.