NatLabRockies / NatLabRockies/H2Integrate
Add ECO version of desal
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Add ECO version of desal
H2I includes a desal model.
GreenHEART used to include another option called desal_model_eco.py.
Noted here: https://github.com/NREL/H2Integrate/pull/384#discussion_r2586851780
Proposed solution
It's unclear to me if we need both desal models because I haven't looked into the differences.
If it makes sense to bring this desal model into the new framework, then that is the solution here.
Alternatives considered
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PR #384 discussion and compare H2I's existing desal model with GreenHEART's desal_model_eco.py to establish their differences. Confirm whether both models are needed and whether the ECO model fits the new framework; done means documenting that decision and, if appropriate, bringing the model into H2I.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100