NatLabRockies / NatLabRockies/H2Integrate

Change all electricity flows in the model to be per-timestep

Open
#387 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code cleanup enhancement framework
Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

Change all electricity flows in the model to be per-timestep

Currently in H2I, all electricity flows are listed as e.g. kW when they are in reality kW/hr.
This is due to the hardcoded assumption the timestep is per-hour.

Proposed solution

To begin to tackle #204, we need to first change all electricity flows to be on a per-timestep basis.
In this moment, that is as simple as changing the units for all electricity-related inputs and outputs from kW to kW/hr.
There may be complications for different technologies or tests due to compatibility changes, hence why this is its own issue separate from others.

Alternatives considered

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the repository for electricity-related inputs and outputs currently labeled kW, then inspect the affected tests for hourly assumptions. The work is done when the relevant flows use per-timestep units consistently and the impacted tests pass without compatibility regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.