NatLabRockies / NatLabRockies/H2Integrate
Feature request: on-turbine hydrogen storage
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
On-turbine hydrogen storage
In some previous work for an external partner, we included an on-turbine hydrogen storage model in H2I (when it was GreenHEART). The model was developed by Kottenstette (see NREL/TP-500-34656) and is described in a readme in the PR including it in GreenHEART. While this is not a currently popular concept, it should not be difficult to bring back in and could be of use later.
Proposed solution
Bring back the model files from git history and make the necessary adjustments to reconnect the model to H2Integrate.
Alternatives considered
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the readme and historical commit ad88a642bba5bf039458280ce28e0d8ea72eb8e1, then compare the old model files with the current H2Integrate structure. Trace the integration points needed to reconnect the model; done means the recovered on-turbine hydrogen storage model is usable in H2Integrate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100