NatLabRockies / NatLabRockies/H2Integrate

Make finding resource files more flexible

Open
#329 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
26
Forks
44
Avg merge
3d 22h
Merged PRs (30d)
16

Description

Make finding resource files more flexible

Resource files currently have to live in a subdirectory with the name of the resource type (like wind resource files have to live in "folder"/"wind"). This should be made more flexible to allow for resource files to live in the main folder ("folder"). This can be easily accomplished once PR #313 is merged in.

Proposed solution

  • add call to find_file in check_resource_dir() method in h2integrate/resource/utilities/file_tools.py
  • perhaps update calls to check_resource_dir() in get_data() method of h2integrate/resource/resource_base.py

Alternatives considered

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing PR #313, then read check_resource_dir() in h2integrate/resource/utilities/file_tools.py and its calls from get_data() in h2integrate/resource/resource_base.py. Implement support for resource files in the main folder as well as the resource-type subdirectory, and verify both locations are handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.