NatLabRockies / NatLabRockies/H2Integrate
Living issue (Iron): Possible Bugs or Issues related to Iron Model
Open
@jmartin4u is already working on this.
Since Dec 31, 2025.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
This is a living issue of possible things to improve in the iron models (the models called within IronComponent)
Iron Ore: Finance
- both finance models (
martin_oreandrosner_ore) have zero fixed costs - capacity calculations between
martin_oreandrosner_oreare different, this is confusing:
# Both models include the below logic
ore_produced_wltpy = cost_ds.loc["Ore pellets produced"] # wltpy = wet long tons per year
ore_produced_wmtpy = ore_produced_wltpy * 1.016047 # wmtpy = wet metric tonnes per year
# The line below are only for the Rosner ore model
pf.set_params("capacity", ore_produced_wmtpy / 365) # units/day
# The lines below are only in the Martin ore model
ore_produced_mtpy = ore_produced_wmtpy * 0.98 # mtpy = dry metric tonnes per year
pf.set_params("capacity", ore_produced_mtpy / 365) # units/day
So rosner_ore outputs LCO-Iron ore in USD/wet metric ton but martin_ore outputs LCO-Iron ore in USD/dry metric ton.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.