NatLabRockies / NatLabRockies/H2Integrate
Expose DOC MCM config inputs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Expose DOC MCM inputs
Originally noted by @jmartin4nrel here https://github.com/NREL/H2Integrate/pull/165#pullrequestreview-3022118598:
The next thing I would add (next PR maybe) is to pass cost inputs along from the tech_config/cost_parameters - of which there is currently only one into the echem_mcc.ElectrodialysisCostInputs(). Looking into the imported mcm module, we could make an option to feed it the user_costs option and these "user-provided costs":
Proposed solution
Alternatives considered
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how tech_config and cost_parameters reach echem_mcc.ElectrodialysisCostInputs(), then inspect the imported mcm module's user_costs option and the listed user-provided costs. Done means the DOC MCM configuration exposes the relevant cost inputs and passes them through to the electrodialysis cost inputs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100