NatLabRockies / NatLabRockies/H2Integrate
Make it clear when electricity is AC or DC
Open
Nobody has claimed this yet.
framework
- Dominant language
- Python
- Stars
- 26
- Forks
- 44
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 16
Description
Make it clear when electricity is AC or DC
Prior users of HOPP and H2Integrate have been confused when electricity is considered in AC or DC, e.g. when inputting solar sizes.
Proposed solution
We could pick one of these solutions:
- always append
_acor_dcto the variable name when dealing with electricity. This is straightforward but a bit clunky. - introduce
kW acandkW dcunits into the OpenMDAO units library we're using in H2I. This is good as it could handle units passing and conversion with a little work. - assume electricity is always AC unless it is appended with
_dc. This is the easiest to do, is straightforward, but might leave room for a little confusion from users.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names HOPP and H2Integrate and points to OpenMDAO's units library, but no files or tests are identified. Start by tracing solar-size inputs and electricity variables in those projects, then confirm the AC/DC convention with maintainers; done means one documented, consistently applied convention for affected inputs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100