NatLabRockies / NatLabRockies/EnergyPlus
Replace `Array1D` instances for types other than `Real64` with `EPVector`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 490
- Avg merge
- 6d 21h
- Merged PRs (30d)
- 22
Description
EPVector is a much smaller template (i.e., faster to compile and generates less code) than Array1D and most of the unnecessary weight has to do with arithmetic operations that are not applicable to string and class objects. I am including int in this targeted removal but I think most EnergyPlus instances of Array1D are arrays of indices and the contents are not manipulated numerically.
Once this issue is resolved, Array1D<Real64> can also be converted to EPVector.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating EnergyPlus uses of Array1D with int, string, and class types, then compare those sites with EPVector; done means replacing the applicable non-Real64 instances while leaving Array1D for after issue 8908 is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100