NatLabRockies / NatLabRockies/EnergyPlus

Add reference name for coilSystem:Cooling:Water object to be able to model Faults

Open
#8,941 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.6k
Forks
490
Avg merge
6d 21h
Merged PRs (30d)
22

Description

Issue overview

This is a suggestion made by @mjwitte when reviewing the waterside economizer new feature in PR #8466.

Details

Some additional details for this issue (if relevant):

"This \reference name isn't used anywhere, so it's not needed. I see that Coilsystem:Cooling:DX has a similar name that is referenced in FaultModel:TemperatureSensorOffset:CoilSupplyAir. I'm not suggesting this PR needs to add fault support for this system type, but you should post a new issue to have it added at some point.
"

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CoilSystem:Cooling:Water object and the analogous CoilSystem:Cooling:DX reference used by FaultModel:TemperatureSensorOffset:CoilSupplyAir. Confirm where the reference name is defined and how it is consumed; the work is done when the water cooling coil system can be identified for fault modeling in the same manner.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.