NatLabRockies / NatLabRockies/EnergyPlus
Choose one implementation of LU decomp/backsub for WindowManager
Open
Nobody has claimed this yet.
NotIDDChange
Performance
Refactoring
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 490
- Avg merge
- 6d 21h
- Merged PRs (30d)
- 22
Description
Issue overview
The WindowManager module has two identical (as far as I can tell, both copied from Numerical Recipes in FORTRAN) implementations of LU decomposition/backsubstitution: LUDCMP/LUBKSB and LUdecomposition/LUsolution. That feels like one too many. At least.
Checklist
- Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the WindowManager module and comparing the callers of LUDCMP/LUBKSB with those of LUdecomposition/LUsolution. Trace which implementation is still needed and check the surrounding numerical code before choosing one. Done means one implementation is retained, the duplicate is removed, and the existing project tests continue to pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100