NatLabRockies / NatLabRockies/EnergyPlus
Eliminate uses of ObjexxFCL ArrayX arithmetic operators
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 490
- Avg merge
- 6d 21h
- Merged PRs (30d)
- 22
Description
Issue overview
Eliminate use of Array[1-5]D +=, -=, *=, and /= operators and eliminate those operators from the ObjexxFCL template hierarchy. This is less of an issue now that we are using EPVector, which is a much smaller template, for many objects. However, we should still not use these. Loops work.
Details
Some additional details for this issue (if relevant):
- Platform (Operating system, version)
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
- Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating uses of Array[1-5]D +=, -=, *=, and /=, then inspect the ObjexxFCL template hierarchy and existing EPVector usage. The work is done when those Array arithmetic operators are no longer used or defined and equivalent loop-based behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100