NatLabRockies / NatLabRockies/EnergyPlus

Stratified water heat autosize options causing program crashes

Open
#8,451 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.6k
Forks
490
Avg merge
6d 21h
Merged PRs (30d)
22

Description

Issue overview

The EnergyPlus program may crash when the stratified water heat tank inputs are set to autosizing some input parameters such as tank size and height. The issue can be demonstrated by the attached .idf file which is slightly modified from the example file 5ZoneWaterSystems.idf: in the file a stratified water heater replaces the original mixed water heat in the example 5ZoneWaterSystems.idf file.

The temporary workaround is either switching to a mixed water heater (WaterHeater:Mixed), or setting the stratified tank size and height values manually.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version): All
  • Version of EnergyPlus 9.3-9.4
  • Helpdesk ticket number 15592
Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here
    5ZoneWaterSystems_changed_to_stratified.zip
    )
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash with the attached 5ZoneWaterSystems_changed_to_stratified.idf file, using EnergyPlus 9.3 or 9.4, and compare it with the original example and the manual-size workaround. Trace the stratified water heater autosizing path for tank size and height. Done means the example runs without crashing when those fields are autosized, with a regression check covering the defect.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.