NatLabRockies / NatLabRockies/EnergyPlus

ZoneControl:Thermostat should move the extensible fields at the end

Open
#7,484 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

IDDChange
Dominant language
C++
Stars
1.6k
Forks
490
Avg merge
6d 21h
Merged PRs (30d)
22

Description

Issue overview

Here is the current IDD:

ZoneControl:Thermostat,
  A1 , \field Name
  A2 , \field Zone or ZoneList Name
  A3 , \field Control Type Schedule Name
  A4 , \field Control 1 Object Type
  A5 , \field Control 1 Name
  A6 , \field Control 2 Object Type
  A7 , \field Control 2 Name
  A8 , \field Control 3 Object Type
  A9 , \field Control 3 Name
  A10, \field Control 4 Object Type
  A11, \field Control 4 Name
  N1 ; \field Temperature Difference Between Cutout And Setpoint

Field N1 should be moved betwen A3 and A4, so we can treat the Control Object Type / Control Object Name as extensible fields (in openstudio in particular, see https://github.com/NREL/OpenStudio/issues/3584#issuecomment-527249170)

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number
Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the current IDD definition for ZoneControl:Thermostat and inspect the field ordering. Move the Temperature Difference Between Cutout And Setpoint field between A3 and A4, then verify that the resulting IDD still parses and preserves the extensible control object fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.