NatLabRockies / NatLabRockies/EnergyPlus

Water Source Summary incorrect values

Open
#6,367 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Defect
Dominant language
C++
Stars
1.6k
Forks
490
Avg merge
6d 21h
Merged PRs (30d)
22

Description

Issue overview

When implementing rain collection in the model, reported value of Water Supplied by Utility appears to be greater than the total end use water although no overflow occurred.

example output:

image

I think that in OutputReportTabular.cc variable gatherMains should be gatherMains=gatherMains + StorageChange since gatherMains is actually taking into account all the water that the different water equipments were supplied with including gray and rain water as indicated in the e+ Input Output Reference :

1.54.1.2.10 Water Use Equipment Mains Water Volume [m3]
The total volume of water (hot+cold) supplied to the equipment and consumed down the drain, in
units of cubic meters (m3). This output is also added to a meter with Resource Type = MainsWater, End
Use Key = WaterSystems, and Group Key = Plant. The sub-categories may be entered as any type (e.g.,
Laundry, Dish Washing, etc. defined in WaterUse:Equipment object input for End-Use Subcategory) with
General being the default sub-category (ref. Output Meter)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in OutputReportTabular.cc and trace how gatherMains contributes to the Water Source Summary during rain collection. Compare that calculation with the Water Use Equipment Mains Water Volume definition in the cited EnergyPlus Input Output Reference. Done means the reported Water Supplied by Utility value matches the actual mains contribution when gray or rain water is also used and no overflow occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.