NYCPlanning / NYCPlanning/data-engineering
PLUTO: add data check for corrections file
Open
Nobody has claimed this yet.
db-pluto
QA
- Dominant language
- Python
- Stars
- 43
- Forks
- 3
- Avg merge
- 23h 3m
- Merged PRs (30d)
- 44
Description
Following #1687, we need to add a new data check that ensures all corrections, except ownername type, have a bbl.
With the current code, you are able to add a correction with bbl left blank for any field.
This aligns with the GDE Manual docs. See the screenshot below:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin by reviewing issue #1687 and locating the existing corrections-file data checks in the repository. Add a check requiring bbl for every correction type except ownername, then verify that blank bbl values are rejected for other correction types while ownername remains allowed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-engineering
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100