NYCPlanning / NYCPlanning/data-engineering
Handle product folder names, DO folder names, db names in graceful way
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 43
- Forks
- 3
- Avg merge
- 23h 3m
- Merged PRs (30d)
- 44
Description
I wrote a horrible hack
https://github.com/NYCPlanning/data-engineering/blob/main/dcpy/lifecycle/builds/plan.py#L344-L346
Right now, gft has
- a folder named
green_fast_trackin our repo - a folder in edm-publishin named
db-green-fast-track - a build db named
db-green-fast-track
This should be resolved, either by
- making folder in repo consistent or vice-versa
- normalizing all these resources (across products) to use one consistent string per product (i.e. just "green-fast-track" in all 3 cases)
- having this be configurable (defined for each product in a recipe or something like that)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with dcpy/lifecycle/builds/plan.py at lines 344-346 and trace how product folders, edm-publishin folders, and build database names are derived. Compare the existing green_fast_track and db-green-fast-track conventions, then define which consistent or configurable naming behavior should apply across products before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-engineering
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100