NYCPlanning / NYCPlanning/data-engineering

Recipes: Raise Exception on Previous Version parsing/resolution failure

Open
#1,200 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
43
Forks
3
Avg merge
23h 3m
Merged PRs (30d)
44

Description

https://github.com/NYCPlanning/data-engineering/blob/90497a2886a411a71e4746016b31ed09f838b18e/dcpy/lifecycle/builds/plan.py#L87-L101

We should only try to resolve the previous version when we need to, and not by bypass errors.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading dcpy/lifecycle/builds/plan.py lines 87-101, focusing on when the previous version is resolved and how failures are handled. Trace the relevant callers to determine when resolution is needed; done means required parsing or resolution failures raise an exception instead of being bypassed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.