NWChemEx / NWChemEx/TensorWrapper
Consolidate `to_vector` functionality
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 33m
- Merged PRs (30d)
- 6
Description
There are currently two different functions that more or less convert a TensorWrapper to a std::vector<double>. to_vector_from_pimpl lives in src/tensorwrapper/tensor/detail_/pimpl.cpp, and to_vector is in include/tensorwrapper/tensor/conversions.hpp. These two should be consolidated into a single function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare to_vector_from_pimpl in src/tensorwrapper/tensor/detail_/pimpl.cpp with to_vector in include/tensorwrapper/tensor/conversions.hpp, starting from both function entry points and their TensorWrapper usage. Consolidate the duplicate functionality into one function and confirm that only the intended implementation remains available to callers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100