NWChemEx / NWChemEx/TensorWrapper
Reallocate/Reshape in Ctor
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 33m
- Merged PRs (30d)
- 6
Description
For any of TensorWrapper's ctors which take a Buffer, the ctor should make sure that non-empty Buffers are consistent with the shape and allocators provided. This means the Buffer should be reshaped and/or reallocated as needed. If the Buffer is empty, then we assume that shape and allocator are being used as hints for how to eventually fill the Buffer (and nothing needs to be done until the buffer is filled).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating TensorWrapper constructors that accept a Buffer, then inspect the Buffer shape and allocator interfaces they use. The change is complete when non-empty buffers are reshaped or reallocated to match the supplied shape and allocator, while empty buffers remain unchanged until filled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100