NWChemEx / NWChemEx/TensorWrapper

Failing unit tests with -s flag

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
0
Forks
0
Avg merge
5h 33m
Merged PRs (30d)
6

Description

Issue Description

This is the same issue originally submitted for Chemist, but now belongs to TensorWrapper.

Various unit tests fail when one runs tests with -s flag although without this flag all these tests pass.

How to Reproduce

> ./test_tensorwrapper -s
.
.
.
/home/keceli/soft/nwx/local/TensorWrapper/tests/sparse_map/sparse_map/sparse_map.cpp:145: PASSED:
  REQUIRE( lhs_v == corr_lhs )
/home/keceli/soft/nwx/local/TensorWrapper/tests/sparse_map/sparse_map/sparse_map.cpp:145: FAILED:
  REQUIRE( lhs_v == corr_lhs )
due to unexpected exception with message:
  PIMPL not set. Did you move from this instance?
.
.
.
/home/keceli/soft/nwx/local/TensorWrapper/tests/sparse_map/sparse_map/sparse_map.cpp:467: PASSED:
  REQUIRE( result == rhs )
/home/keceli/soft/nwx/local/TensorWrapper/tests/sparse_map/sparse_map/sparse_map.cpp:467: FAILED:
  REQUIRE( result == rhs )
due to unexpected exception with message:
  PIMPL not set. Did you move from this instance?

Other Potentially Helpful Information

-s flag is supposed to include successful tests in the output, so these failures might be related to how Catch is handling the output rather than a problem in TensorWrapper.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running ./test_tensorwrapper with and without -s, then inspect tests/sparse_map/sparse_map/sparse_map.cpp around lines 145 and 467. Trace how Catch handles successful-test output and the reported “PIMPL not set” exception. Done means the affected tests behave consistently with and without -s and the relevant test output is correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.