NWChemEx / NWChemEx/TensorWrapper
Update Excalidraw Design
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 0
- Avg merge
- 5h 33m
- Merged PRs (30d)
- 6
Description
As code is written the design may need tweaked. This issue tracks the changes that need to happen to the Excalidraw document. It's probably easier to just make all these changes at once.
- Move
Buffer::reallocatetoAllocator- Allocation makes buffers, attempting to reallocate in the buffer leads to weird scenarios where you ask a TABuffer to reallocate itself as say a TAMM buffer. Thus I think reallocation needs to move up a level to
Allocator::reallocate(Buffer&).
- Allocation makes buffers, attempting to reallocate in the buffer leads to weird scenarios where you ask a TABuffer to reallocate itself as say a TAMM buffer. Thus I think reallocation needs to move up a level to
- Similarly I think
reshapemay need moved to. - Revisit expression layer. As it's mocked-up I think we need to actually implement two expression layers (one for the buffer and one for TW proper). I think we can get by with just one if we drop the layer associated with the buffer.
- add
reshape(Buffer&)function toShape
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Excalidraw document and review the listed Buffer, Allocator, Shape, and expression-layer concepts. Resolve whether reallocation and reshape belong at the allocator or shape level, and whether one or two expression layers are needed. Done means the design document reflects a settled architecture and all listed changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100