NWChemEx / NWChemEx/PluginPlay

Expose submodule input API for run/run_as

Open
#98 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
C++
Stars
13
Forks
1
Avg merge
43m
Merged PRs (30d)
4

Description

Under the hood the call to a module passes in the type-erased inputs and the type-erased submodules; however, the public API of run/run_asonly lets the user set inputs. The original motivation behind this assumed that the ModuleManager would be the one switching submodules; however, at least for
unit testing purposes it is convenient to be able to just pass in the submodule you want.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the public run and run_as entry points and how they currently accept inputs, then inspect the type-erased inputs and submodules described in the issue. Done means callers can provide the desired submodule through the public API, including for unit testing, without relying on ModuleManager switching it.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.