NWChemEx / NWChemEx/PluginPlay
Problem wrapping implicitly converted objects
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 13
- Forks
- 1
- Avg merge
- 43m
- Merged PRs (30d)
- 4
Description
I haven't looked into it too much, but I get a signal (can't remember if it was a segfault) when I try to let a module implicitly convert say T0 = Chemist::braket::BraKet(aos, t_e, aos) into T1 = Chemist::braket::BraKet(aos, op_base_type, aos) when calling a module satisfying the PT EvaluateBraKet<T1>. I think it's from PluginPlay taking a reference to the implicitly created T1 object. AFAIK BraKet is working correctly, the problem is in PluginPlay
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how PluginPlay invokes a module satisfying the PT EvaluateBraKet when T0 = Chemist::braket::BraKet(aos, t_e, aos) is implicitly converted to T1 = Chemist::braket::BraKet(aos, op_base_type, aos). Reproduce the reported signal and determine whether PluginPlay retains a reference to the implicitly created object. Done means the conversion path no longer produces the reported failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100