NWChemEx / NWChemEx/PluginPlay
DEFINE_PLUGIN shouldn't inline the function
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 13
- Forks
- 1
- Avg merge
- 43m
- Merged PRs (30d)
- 4
Description
As the title says. If people want it inlined they should do: inline DEFINE_PLUGIN(...). In theory this is an easy fix, but I'm putting it off incase it breaks downstream repos.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DEFINE_PLUGIN macro and inspect how it applies inlining. Check existing uses and consider downstream compatibility, as the issue specifically warns that changing this behavior may affect downstream repositories. Done means DEFINE_PLUGIN no longer inlines the function by default, while callers can request inlining explicitly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100