NWChemEx / NWChemEx/PluginPlay
Misleading error message on module readiness
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 13
- Forks
- 1
- Avg merge
- 43m
- Merged PRs (30d)
- 4
Description
Describe the bug
The new error messages for not ready modules (which are great), will report that the inputs of a module are not ready if one of its submodules is not set.
To be clear this was happening at the following level (not sure if relevant that is was a submodule):
Failure:
due to unexpected exception with message:
Submodules that are not ready:
MO Charges:
Inputs that are not ready:
Molecular Orbitals
Molecule
Submodules that are not ready:
S Builder is not set.
Setting an S Builder allowed everything to run (there was no issue with the inputs).
Expected behavior
Would be more clear if only the missing submodule was reported.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Reproduce the reported module-readiness failure, trace the readiness error reporting, and add a regression test showing that an unset submodule is reported without incorrectly listing its inputs; the test should pass with the expected message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100