NWChemEx / NWChemEx/ParallelZone
Cereal's installed CMake target changed with v1.3.1
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 1
- Avg merge
- 40m
- Merged PRs (30d)
- 3
Description
Describe the Issue
Currently, we are pinned at cereal version 1.3.0 (CMakeLists.txt#L73), so technically this is not a problem yet.
In cereal v1.3.1, the installed CMake target name changed from cereal to cereal::cereal. If we want to update to a new version in the future, we will need to fix how we refer to cereal in cmaize_find_or_build_dependency(). It should be an easy fix - just change FIND_TARGET cereal to FIND_TARGET cereal::cereal (CMakeLists.txt#L75).
Related
- I noted this breaking change in OSCiLab/cereal#862.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read CMakeLists.txt around lines 73-75 and inspect how cmaize_find_or_build_dependency() uses FIND_TARGET for cereal. Update the target reference for cereal v1.3.1 compatibility, then verify the dependency configuration still resolves the installed cereal target.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100