NWChemEx / NWChemEx/ChemCache

Presence of "mini.nw" in reference_data/basis_sets/default slightly impedes development

Open
#91 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
C++
Stars
2
Forks
1
Avg merge
9h 2m
Merged PRs (30d)
3

Description

With the file reference_data/basis_sets/default/mini.nw present, it makes it a tad bit harder to do development if only the sto-3g basis set is used in the master branch. With the file present, the resulting development workflow of generate_basis.py results in the mini basis set being generated, which leads to extra cleaning of the mini basis set files that are generated.

My suggestion is to either add the mini basis set data to the master branch, or to remove mini.nw to prevent generating the basis set files. What do you all think?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with reference_data/basis_sets/default/mini.nw and generate_basis.py, then inspect how the master branch handles the sto-3g and mini basis sets. Confirm whether mini data is intended to be present; done means the chosen repository state no longer causes unwanted mini basis set files during development.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, data
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.