NVIDIAGameWorks / NVIDIAGameWorks/rtx-remix

[Runtime Bug]: rtx.captureHotKey = Not Working

Open
#652 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug jira runtime
Dominant language
No language data
Stars
1.7k
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

It looks like overwriting the rtx.conf command for rtx.captureHotKey = doesn't seem to be working. I've been trying all different kinds of key strings to get it working, but it always defaults to CTRL, Shift, Q. I even tried removing the whitespaces from the custom string. For example,

rtx.captureHotKey = CTRL, Shift, P
rtx.captureHotKey = CTRL,SHIFT,P
rtx.captureHotKey = ALT, P
rtx.captureHotKey = I, O, P

It's strange because the game will allow me to capture through the GUI and the default shortcut, but won't allow capture through my custom command.

I had a brief conversation with NV_Mark in Discord who was very kind/helpful in taking a peak at the problem and agreed that the behavior was not expected, and believed it perhaps had something to do with https://github.com/NVIDIAGameWorks/dxvk-remix/blob/main/src/util/config/config.cpp#L1316 .

How do you reproduce the bug?

Open rtx.conf, write a line rtx.captureHotKey = with any key combination available in the https://github.com/NVIDIAGameWorks/dxvk-remix/blob/3851ec6eb4ec0537288fb55588c22cdc662675a5/src/util/util_keybind.h#L86 directory. Launch game with remix, and see that your custom command won't generate a capture.

What is the expected behavior?

To allow our custom key to generate a capture.

Version

main+3851ec6e

Logs

remix-dxvk.log
d3d9.log

Crash dumps

No response

Media

Screenshot 2024-10-14 174226

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with rtx.conf and the configuration handling near line 1316 of src/util/config/config.cpp, then inspect the key combinations listed around line 86 of src/util/util_keybind.h. Reproduce with a custom rtx.captureHotKey value and launch the game; done means the configured combination generates a capture rather than only the default shortcut.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.