NVIDIAGameWorks / NVIDIAGameWorks/rtx-remix

[Runtime Bug]: RTXDI Causing lights to not contribute to GI

Open
#505 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug jira runtime
Dominant language
No language data
Stars
1.7k
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

the combined effect of the settings "Indirect Sample Stealing" and "Steal Boundary Samples When Outside Of Screen" cause spot lights to no longer sample when outside of the players view

going through and individually disabling settings in RTXDI these seem to be the only two that effect this particular issue
you also might notice in the shots I sent the denoiser wasnt enabled however enabling it had no effect, ray reconstruction does but it only seems to be because "Steal Boundary Samples When Outside Of Screen" gets disabled with it on, turning it back on with RR causes the same effect

Screenshot 2024-05-11 142153
Screenshot 2024-05-11 142231
Screenshot 2024-05-11 143746

How do you reproduce the bug?

in a relatively dark place spawn in a bright spotlight, then move and look away from it such that it or the cone of light it would make is not in view, you should notice a drop in brightness of the surrounding light that would otherwise be bounced from where the spotlight is shining, you also might need to adjust the angle you are looking, I noticed the effect would change somewhat based on vertical view angle, so if the spotlight was pointing up then looking up would cause the bug where as looking down wouldnt, and vise versa with a downward pointing spotlight

if you are having trouble replicating the issue (sorry if I'm not good at explaining) I've included a shot that shows what my particular setup was, for my test I was located on the far side of the large dark room next to the staircase leading out in gm_construct in Garry's Mod, the green spotlight was placed by me and the one at the top of the stars was part of the map. however its worth noting I experienced this effect in other parts of the map as well.

Screenshot 2024-05-11 144203

What is the expected behavior?

The expected behavior is that the light should not nearly vanish from the scene entirely, and continue to contribute to GI

Version

dxvk-remix-1cd190c-538-release bridge-remix-1b485b6-69-release

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Garry's Mod on gm_construct with a bright spotlight outside the view, then compare the effects of disabling "Indirect Sample Stealing" and "Steal Boundary Samples When Outside Of Screen" individually. Done means the spotlight continues contributing to GI instead of nearly vanishing when the player looks away.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.