NVIDIAGameWorks / NVIDIAGameWorks/rtx-remix
Allow AperturePBR_Portal material-shader to properly function on replacement meshes.
Open
@MarkEHenderson is already working on this.
Since Nov 15, 2023.
jira
runtime
- Dominant language
- No language data
- Stars
- 1.7k
- Forks
- 99
- PR merge metrics
- No merged PRs in 30d
Description
In order to get AperturePBR_Portal material shader working, a pair of texture hashes needed to be configured:
rtx.rayPortalModelTextureHashes = textureHash1, textureHash2
The code block enforcing this requirement here.
However replacement materials don't have such runtime hashes thus this limitation prevents portals to be used on replacement meshes.
Mark's statement on this:
That code could be changed to check the overrideMaterialData's type, and check if it already has a portal_index property.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.