NVIDIAGameWorks / NVIDIAGameWorks/rtx-remix

[Runtime Bug]: Portal 2 - BLAS merging regressions on batched world geometry since 1.1.0

Open
#1,005 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug runtime triage
Dominant language
No language data
Stars
1.7k
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

After updating my Portal 2 Compatibility Mod to support the latest version of the remix runtime, multiple people and my self noticed world geometry breaking on certain angles / maps.

  • checking Minimize BLAS Merging in the Geometry section seems to help but does not completely fix it
  • this definitely did not happen on earlier builds of the runtime
  • world geometry is batched and gets culled so geometry hashes constantly change

I'll try to pinpoint the commit where it started happening and will update the post.

edit:
How do you reproduce the bug?
  1. ToT of remix runtime or any version after this commit: https://github.com/NVIDIAGameWorks/dxvk-remix/commit/4ead07825bf59eb55a4941ef0137cf2d31595afc
  • Note: being on a commit so far back can cause issues with the remixApi implementation in the comp mod
  1. Use the portal 2 compatibility mod (without the custom remix runtime)
    https://github.com/xoxor4d/p2-rtx/releases/tag/v2.2.3

  2. Load the game and use console command map sp_a1_wakeup and notice geo issues as can be seen in the attached video

Version

ToT

Media

Issue:
https://drive.google.com/file/d/1fy5mICuivPuMS46NrmNHNQeDnOkKkBO3/view?usp=sharing

With Minimize BLAS Merging checked:
https://drive.google.com/file/d/1dVLBVF-58IH5EVIQfn0vNTcMneGjkL8H/view?usp=sharing

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing commit 4ead07825bf59eb55a4941ef0137cf2d31595afc, then reproduce the regression with the Portal 2 compatibility mod using map sp_a1_wakeup. Compare geometry behavior before and after that commit, including with Minimize BLAS Merging enabled. Done means the batched world geometry no longer breaks or is incorrectly culled on the reported map.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.