NVC++ doesn't define `__cplusplus` correctly in C++20/C++23 mode, which causes issues with our C++ dialect detection.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.4k
- Forks
- 270
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 39
Description
NVC++ doesn't define __cplusplus correctly for C++20/C++23 mode (it defines it as 201709UL). Currently, we check for C++ dialect using __cplusplus in one of our config headers:
https://github.com/NVIDIA/stdexec/blob/main/include/stdexec/__detail/__config.hpp#L18-20
We should probably remove this check for the time being, or modify it for NVC++.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read include/stdexec/__detail/__config.hpp at lines 18-20, then verify how NVC++ reports __cplusplus in C++20 and C++23 modes. Determine the smallest configuration change that avoids incorrect dialect detection for NVC++, and confirm that the resulting checks distinguish the supported C++ modes correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100