NVIDIA / NVIDIA/stdexec

asioexec configure_file should output to binary directory

Open
#1,533 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.4k
Forks
270
Avg merge
3d 6h
Merged PRs (30d)
39

Description

https://github.com/NVIDIA/stdexec/commit/35a3e31590e736fbb7dd55324b3a7f991a059ce3#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR440-R441

set(ASIOEXEC_ASIO_CONFIG_FILE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/include/asioexec)
configure_file(include/asioexec/asio_config.hpp.in ${ASIOEXEC_ASIO_CONFIG_FILE_PATH}/asio_config.hpp)

I think setting the output to ${CMAKE_CURRENT_BINARY_DIR}/stdexec_generated/include/asioexec and then added via target_include_directories(stdexec PUBLIC ${CMAKE_CURRENT_BINARY_DIR}/stdexec_generated/include) is the better way here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the configure_file call in the linked commit diff and inspect how the generated asio_config.hpp path is added to the target include directories. Done means configuration writes the header under the binary directory, the generated include directory is exposed to stdexec, and the source tree is not modified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.